Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

Multiple FCM Account Support #21

Merged
merged 3 commits into from
Jan 16, 2023
Merged

Multiple FCM Account Support #21

merged 3 commits into from
Jan 16, 2023

Conversation

anujgandhi
Copy link

Hello,

I have modified the below files for supporting multiple FCM account i.e. combinations of Sender ID and Sever Key. This is to handle a scenario where this library needs to be part of say a Microservices handling FCM request from multiple applications.

Laravel-FCM/src/Request/Request.php
Laravel-FCM/src/Sender/FCMSender.php
Thank you

Anuj Gandhi

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 87.87% // Head: 86.44% // Decreases project coverage by -1.43% ⚠️

Coverage data is based on head (3c8435e) compared to base (4caeb22).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 3c8435e differs from pull request most recent head 0333636. Consider uploading reports for the commit 0333636 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #21      +/-   ##
============================================
- Coverage     87.87%   86.44%   -1.44%     
  Complexity      254      254              
============================================
  Files            30       30              
  Lines           660      745      +85     
============================================
+ Hits            580      644      +64     
- Misses           80      101      +21     
Impacted Files Coverage Δ
src/Request/BaseRequest.php 100.00% <100.00%> (ø)
src/Message/PayloadDataBuilder.php 78.57% <0.00%> (-6.05%) ⬇️
src/Response/GroupResponse.php 81.25% <0.00%> (-0.90%) ⬇️
src/Response/DownstreamResponse.php 91.30% <0.00%> (-0.47%) ⬇️
src/FCMManager.php 0.00% <0.00%> (ø)
src/Facades/FCM.php 0.00% <0.00%> (ø)
src/Message/Topics.php 100.00% <0.00%> (ø)
src/Message/Options.php 100.00% <0.00%> (ø)
src/Facades/FCMGroup.php 0.00% <0.00%> (ø)
src/Facades/FCMTopic.php 0.00% <0.00%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@anujgandhi anujgandhi closed this Dec 22, 2022
@williamdes williamdes reopened this Dec 22, 2022
Copy link
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, I will dive into it to see how I can merge this

@williamdes williamdes added the enhancement New feature or request label Dec 22, 2022
@williamdes williamdes self-assigned this Dec 22, 2022
@williamdes
Copy link
Member

I started re-working this starting by 3c8435e

@williamdes williamdes added this to the 1.8.0 milestone Jan 16, 2023
@williamdes williamdes merged commit 7edc3e4 into code-lts:main Jan 16, 2023
@williamdes
Copy link
Member

I merged your changes (7edc3e4) after some more changes: 76c00c3

@williamdes
Copy link
Member

Released ! 🎉
https://github.com/code-lts/Laravel-FCM/releases/tag/1.8.0

Be sure to use the parameters in the right order, I changed the order while working on it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants