fix:Add support for TimeDelta type in Python and Rust #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badmonster0
reviewed
Apr 22, 2025
There was a problem hiding this comment.
Thanks for making this PR!
This PR fails to build:
https://github.com/cocoindex-io/cocoindex/actions/runs/14589192202/job/40959965493?pr=368
You can follow this guide to build and test it locally:
|
@Keerthi421 friendly follow up to see if you are still actively working on this? thanks! |
|
close since this has been up for 2 weeks, and seems no longer active :) thanks a lot for taking a look! |
lemorage
added a commit
to lemorage/cocoindex
that referenced
this pull request
May 16, 2025
badmonster0
pushed a commit
that referenced
this pull request
May 20, 2025
* feat: add support for TimeDelta type in Python and Rust Continuation on #368 * refactor: update duration parser to align with ISO 8601 standard - Replaced naive parsing with structured component-based approach - Enhanced both iso8601 and human-readable parsers with proper validation and unit order checks - Added more tests, achieving 97.52% test coverage * feat: make duration parser lenient by allowing duplicate and out of order units * refactor: inline code with some cleanups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Issue #344
This PR implements support for the TimeDelta type in CocoIndex as requested in issue #344.
Changes:
-->Added TimeDelta = Annotated[datetime.timedelta, TypeKind('TimeDelta')] in Python typing module
-->Added TimeDelta variant to Rust's type system
-->Implemented conversion between Python's datetime.timedelta and Rust's chrono::Duration
-->Added PostgreSQL storage support using the native interval type
Testing:
-->Tests should be added to verify:
-->Python type analysis correctly identifies datetime.timedelta objects
-->Conversion between Python and Rust time delta representations works correctly
-->PostgreSQL storage and retrieval works as expected
This addresses #344.