-
-
Notifications
You must be signed in to change notification settings - Fork 124
Updated the UVIndex implementation #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @roelvanhintum! https://travis-ci.org/cmfcmf/OpenWeatherMap-PHP-Api/jobs/522113766#L499 |
@cmfcmf i've changed the tests, but travis-ci is still having some problems with composer i can't figure out. |
Thank you for adjusting the tests. The build was failing on hhvm, which Composer doesn't support any longer. I therefore removed support for hhvm. I'm sorry this takes so long - I'm hesitant to merge this as this, because this would break backwards compatiblity with the current implementation, if I'm reading the changes correctly. I hope to find time next week to take another look at your PR and possibly make it backwards compatible (maybe via an opt-in switch). |
I couldn't match the old implementation with the API, which was the reason i changed it. Maybe this should be pushed to a major release, to make clear things can break? |
I've gone through this PR and updated some minor bits and pieces. I also fixed historic uv index retrieval and tests. This should be good to go now. Thank you again for your work and patience, @roelvanhintum! |
@cmfcmf You're welcome and thank you! |
No description provided.