Skip to content

Add missing extension requirements #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2018
Merged

Add missing extension requirements #129

merged 1 commit into from
Nov 1, 2018

Conversation

MindaugasJackunas
Copy link

No description provided.

@cmfcmf
Copy link
Owner

cmfcmf commented Nov 1, 2018

Hi @MindaugasJackunas, thank you for this PR!
Could you elaborate on the differences between xml, libxml and simplexml? Also could you remove the curl requirement, because it is not strictly required to use this library. See: https://github.com/cmfcmf/OpenWeatherMap-PHP-Api/blob/92edee8c7d31913a20d0775baa1bb13782cd54e0/Cmfcmf/OpenWeatherMap/Fetcher/FileGetContentsFetcher.php

@MindaugasJackunas
Copy link
Author

Hi @MindaugasJackunas, thank you for this PR!
Could you elaborate on the differences between xml, libxml and simplexml? Also could you remove the curl requirement, because it is not strictly required to use this library. See: https://github.com/cmfcmf/OpenWeatherMap-PHP-Api/blob/92edee8c7d31913a20d0775baa1bb13782cd54e0/Cmfcmf/OpenWeatherMap/Fetcher/FileGetContentsFetcher.php

I have moved ext-curl requirement to suggestion section.

Removed ext-xml requirement (has been added by mistake).

Places where ext-libxml and ext-simplexml are used:

@cmfcmf
Copy link
Owner

cmfcmf commented Nov 1, 2018

Thank you very much!

@cmfcmf cmfcmf merged commit 1c234c0 into cmfcmf:master Nov 1, 2018
@MindaugasJackunas MindaugasJackunas deleted the composer-require-update branch November 1, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants