Removed the 'not-so-forecast' measure #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it won't happen again
|
I've adjusted the Forecast tests to match the new behaviour. The other tests fail, because http://httpbin.org/html is currently not reachable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for #121. This removes the 'not-so-forecast' measure in
\Cmfcmf\OpenWeatherMap\WeatherForecast.In summary, when we fixed #119, I believe that the 'not-so-forecast' problem fixed by #64 may have been gone because the code used to remove such forecasts involved a timezone-related issue.
Currently, this PR breaks 2 assertions in
WeatherForecastTestbecause these run under the assumption of the measure being present. If we can be sure that the 'not-so-forecasts' aren't there in the first place, we can modify the test as well.If the measure is found to be necessary, I'll close this PR.