Skip to content

Pluggable discovery initial implementation #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

PaulStoffregen
Copy link

Here's an initial implementation for PluggableDiscovery.

The BoardPort class is used for JSON parsing, but other than a copy constructor I have not made any changes to BoardPort yet.

Please accept my apology in advance if this pull request is incorrect or goes to the wrong place. I'm not an expect with git & github. This pull request is meant to request adding to @cmaglie pluggable-discovery branch, rather than the main Arduino repository.

@facchinm
Copy link
Collaborator

facchinm commented Oct 1, 2018

Hi @PaulStoffregen, I pushed your commits to cmaglie/pluggable-discovery so they got added to PR arduino#8038 . Maintainers/collaborators can push to feature branches by just adding the correct remote and pushing to the PR branch 😉

@PaulStoffregen
Copy link
Author

PaulStoffregen commented Oct 1, 2018

Thanks!

@cmaglie cmaglie closed this Oct 1, 2018
@PaulStoffregen
Copy link
Author

@facchinm - Any chance you could give me a pointer on "just adding the correct remote and pushing to the PR branch"? I'm not a git expert....

I have a new commit to add the PluggableDiscovery metadata, rather than (mis)using the online field. But how to push it to that pull request? (and not accidentally mess up anything else on Arduino's main repository!)

PaulStoffregen@07eee5e

@PaulStoffregen
Copy link
Author

Ok, I think I found a way, using another clone from Cristian's fork.

Someday I ought to invest more time into learning the finer points of git.....

@facchinm
Copy link
Collaborator

facchinm commented Oct 2, 2018

On git you can setup many "remotes" for a single repo, so if you are working on branch foo (locally) and want to push to cmaglie/pluggable-discovery you need to:

  • add @cmaglie 's repo as a remote with git remote add cmaglie git@github.com:cmaglie/Arduino.git
  • push your branch to his branch with git push cmaglie foo:pluggable-discovery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants