Skip to content

Fix trigger_test_sqlserver test case failure #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lranj
Copy link

@lranj lranj commented May 16, 2019

- use SET NOCOUNT ON so that the number of rows affected by INSERT
  statement is returned instead of the number of rows affected by the trigger
- Refer https://techcommunity.microsoft.com/t5/SQL-Server/UPDATE-with-OUTPUT-clause-8211-Triggers-8211-and-SQLMoreResults/ba-p/383457
@smlsml
Copy link

smlsml commented May 23, 2019

I wish the title of this commit message was more detailed. While the change being made here will fix the test, that's not the core/direct change being made.

Something like: SET NOCOUNT ON for all insert statements

I also wonder if this will cause compatibility errors for older version of SQL Server?

@smlsml smlsml merged commit d3eb0f2 into cloudvolumes:5-1-stable-with-odbc May 23, 2019
@lranj
Copy link
Author

lranj commented Jun 28, 2019

I wish the title of this commit message was more detailed. While the change being made here will fix the test, that's not the core/direct change being made.

Something like: SET NOCOUNT ON for all insert statements

I also wonder if this will cause compatibility errors for older version of SQL Server?

We will make sure to test AVM on rails 5.1 in all the supported versions of SQLServer. It is included as one of the test strategy for rails 5.1 https://confluence.eng.vmware.com/display/RT/Rails+Upgrade+5.0.7.1+to+5.1.6.1

smlsml pushed a commit that referenced this pull request Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants