-
Notifications
You must be signed in to change notification settings - Fork 2
feat: Add Bool scalar #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import test from 'ava'; | ||
import { DataType } from '@apache-arrow/esnext-esm'; | ||
import { Bool } from './bool.js'; | ||
|
||
[null, undefined].forEach((v) => { | ||
test(`should set values to false when ${v} is passed`, (t) => { | ||
const b = new Bool(v); | ||
t.is(b.Valid, false); | ||
t.true(DataType.isBool(b.DataType)); | ||
}); | ||
}); | ||
|
||
[1, true, 'true', 'Y', 'y', 'TRUE', 'on'].forEach((v, i) => { | ||
test(`should support truthy value '${v}' (${i})`, (t) => { | ||
const b = new Bool(v); | ||
t.is(b.Valid, true); | ||
t.is(b.Value, true); | ||
t.true(DataType.isBool(b.DataType)); | ||
t.is(b.toString(), 'true'); | ||
}); | ||
}); | ||
|
||
[0, false, 'false', 'N', 'n', 'FALSE', 'off'].forEach((v, i) => { | ||
test(`should support falsy value '${v}' (${i})`, (t) => { | ||
const b = new Bool(v); | ||
t.is(b.Valid, true); | ||
t.is(b.Value, false); | ||
t.true(DataType.isBool(b.DataType)); | ||
t.is(b.toString(), 'false'); | ||
}); | ||
}); | ||
|
||
test('should throw when unable to set value', (t) => { | ||
t.throws(() => new Bool({ value: {} }), { message: "Unable to set '[object Object]' as Bool" }); | ||
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
import { Bool as ArrowBool } from '@apache-arrow/esnext-esm'; | ||
import { boolean, isBooleanable } from 'boolean'; | ||
import { isInvalid, NULL_VALUE } from './util.js'; | ||
|
||
export class Bool { | ||
private _valid = false; | ||
private _value = false; | ||
|
||
public constructor(v: unknown) { | ||
this.Valid = v; | ||
return this; | ||
} | ||
|
||
public get DataType() { | ||
return new ArrowBool(); | ||
} | ||
|
||
public get Valid() { | ||
return this._valid; | ||
} | ||
|
||
public get Value() { | ||
return this._value; | ||
} | ||
|
||
public set Valid(value: unknown) { | ||
if (isInvalid(value)) { | ||
this._valid = false; | ||
return; | ||
} | ||
|
||
let val = value; | ||
// Check if this might be a scalar boolean | ||
if (Object.hasOwnProperty.call(value, 'value')) { | ||
val = (value as { value: unknown }).value; | ||
erezrokah marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} | ||
|
||
if (isBooleanable(value)) { | ||
this._value = boolean(value); | ||
this._valid = true; | ||
return; | ||
} | ||
|
||
throw new Error(`Unable to set '${value}' as Bool`); | ||
} | ||
|
||
public toString() { | ||
if (this._valid) { | ||
return String(this._value); | ||
} | ||
|
||
return NULL_VALUE; | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
export const NULL_VALUE = '(null)'; | ||
|
||
export const isInvalid = (value: unknown) => value === null || value === undefined; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.