Skip to content

Do not create data resources when disabled #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2020
Merged

Do not create data resources when disabled #27

merged 2 commits into from
Oct 13, 2020

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Oct 13, 2020

what

  • Do not create data resources when disabled

why

  • Minimize impact of disabled module

@Nuru Nuru requested review from a team as code owners October 13, 2020 01:29
@Nuru Nuru requested review from jamengual and danjbh October 13, 2020 01:29
@Nuru
Copy link
Contributor Author

Nuru commented Oct 13, 2020

/test all

aknysh
aknysh previously approved these changes Oct 13, 2020
View reviewed changes
@Nuru
Copy link
Contributor Author

Nuru commented Oct 13, 2020

/test all

@Nuru Nuru requested a review from aknysh October 13, 2020 03:37
@Nuru Nuru added the bugfix Change that restores intended behavior label Oct 13, 2020
@Nuru Nuru merged commit dd39b07 into master Oct 13, 2020
@Nuru Nuru deleted the disable branch October 13, 2020 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@danjbh danjbh Awaiting requested review from danjbh

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @aknysh