Skip to content

Workaround TF null default bug #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 9, 2020
Merged

Workaround TF null default bug #26

merged 3 commits into from
Oct 9, 2020

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Oct 9, 2020 •
edited
Loading

what

  • Default git_ref to "" instead of null
  • Lambda artifact generation for PRs now uses PR SHA

why

  • Passing null is supposed to make the module use the default value, but in this case it does not
  • Terraform code expects to find artifact with same SHA as Terraform module

references

@Nuru Nuru added the bugfix Change that restores intended behavior label Oct 9, 2020
@Nuru Nuru requested review from a team as code owners October 9, 2020 00:33
@Nuru Nuru requested review from Gowiem and SweetOps October 9, 2020 00:33
osterman
osterman previously approved these changes Oct 9, 2020
View reviewed changes
@Nuru
Copy link
Contributor Author

Nuru commented Oct 9, 2020

/test all

@Nuru
Copy link
Contributor Author

Nuru commented Oct 9, 2020

/test all

@Nuru Nuru merged commit ea43d1a into master Oct 9, 2020
@Nuru Nuru deleted the nullfix branch October 9, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
bugfix Change that restores intended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nuru @osterman