-
-
Notifications
You must be signed in to change notification settings - Fork 12
Change index selectors, update to current standards #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/test all |
/test all |
/test all |
1 similar comment
/test all |
osterman
previously approved these changes
Oct 8, 2020
/test all |
/test all |
/test all |
/test terratest |
/test all |
/test all |
/test all |
/test bats |
/test readme terratest |
/test terratest |
/test all |
osterman
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
~>
to>=
es-cleanup.py
on cloudreach v0.14context.tf
why
~>
inhibits testing new releases.migration
Prior versions had
index
which was a comma-separated list of index names or the special name "all" to indicate all but Kibana indexes, andindex_regex
which was a regular expression for parsing index name and date parts. There was no mechanism for specifying a list of indexes to exclude. This version drops those input variables and instead providesindex_re
andskip_index_re
, both of which are regular expressions. You probably want to anchor your regexes to the beginning of the index name by starting with^
.skip_index_re
, then the index will be skipped (never deleted).-date
part matchesindex_re
, then it will be cleaned up according to the date part.index = "all"
index_re
andskip_index_re
index = "a,xb,c0"
index_re = "^(a|xb|c0)"
andskip_index_re = "^$"
index_regex = "(ipat)-(dpat)"
index_re = "ipat"
and be sureindex_format
is correct for your date formatKeep in mind that fundamentally, this module expects indexes to be in the format of
name-date
so it will not work properly if the regexes end up selecting an index that does not end with-date
. To avoid edge cases, it is wise not to include dashes in your index name or date format.