Skip to content

Convert to TF 0.12. Add tests. Add Codefresh test pipeline. Add slash-command-dispatch GitHub Actions workflow #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 30, 2020

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Apr 30, 2020

what

  • Port module to Terraform 0.12
  • Pin all providers
  • Add example for testing
  • Add bats and terratest for the example
  • Add Codefresh badge to point to the test pipeline in terraform-modules project
  • Update README
  • Add slash-command-dispatch GitHub Actions workflow

why

  • Module currently does not work with 0.12. Much easier syntax
  • Better regression control
  • Automatically test the example on every commit and pull request
  • Provision resources on AWS in the test account and check the outputs for the correct values
  • terraform-modules project contains pipelines for all terraform modules
  • slash-command-dispatch GitHub Actions workflow: In a repo with the GitHub actions workflow present, when a PR is opened, we can comment on the PR with commands /build-readme and /terraform-fmt to rebuild README and format terraform code and push the changes back to the PR repo

related

@aknysh aknysh requested review from osterman and maximmi April 30, 2020 02:30
@aknysh aknysh self-assigned this Apr 30, 2020
@goruha
Copy link
Member

goruha commented Apr 30, 2020

/codefresh run test

@aknysh aknysh merged commit 8f17047 into master Apr 30, 2020
@aknysh aknysh deleted the terraform-0.12 branch April 30, 2020 15:59
@osterman osterman mentioned this pull request Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants