Skip to content

Make SNS optional again #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Make SNS optional again #15

merged 1 commit into from
Oct 12, 2019

Conversation

Nuru
Copy link
Contributor

@Nuru Nuru commented Oct 12, 2019

what

Supplying an sns_arn is supposed to be optional, but #11 made it a requirement because it generated an invalid IAM policy without one. This makes it optional again.

why

SNS notifications are not necessary for this lambda to do its primary job.

@Nuru Nuru requested review from aknysh and osterman October 12, 2019 02:07
@Nuru Nuru merged commit 2d15122 into master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants