Skip to content

Rollback modification of proto file descriptor at client.py #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

ImMin5
Copy link
Member

@ImMin5 ImMin5 commented Aug 22, 2024

Category

  • New feature
  • Bug fix
  • Improvement
  • Refactor
  • etc

Description

  • Rollback proto file descriptor modification at client.py
    python-core has a dependency on protobuf 3.20.3 . This version does not have GetMessageClassat message_factory.py, so we temporarily rolled back to the previous code.

  • protobuf code link for 3.20.3
    The last commit before version 3.20.3 in message_factory.py was on 2022-08-22.

  • protobuf 3.20.3 pypi package relase version date link
    Version 3.20.3 was released on 2022-09-30

Known issue

Signed-off-by: ImMin5 <mino@megazone.com>
@ImMin5 ImMin5 added bug Something isn't working enhancement New feature or request labels Aug 22, 2024
@ImMin5 ImMin5 requested a review from whdalsrnt August 22, 2024 17:09
@ImMin5 ImMin5 self-assigned this Aug 22, 2024
@ImMin5 ImMin5 changed the title Rollback proto file descriptor modification at client.py Rollback modification of proto file descriptor modification at client.py Aug 22, 2024
@ImMin5 ImMin5 changed the title Rollback modification of proto file descriptor modification at client.py Rollback modification of proto file descriptor at client.py Aug 22, 2024
Copy link
Member

@whdalsrnt whdalsrnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@whdalsrnt whdalsrnt merged commit 9a10aa9 into cloudforet-io:master Aug 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request pass/signedoff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants