Add defcustom inf-clojure-prompt-when-set-ns
#46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arichiardi
force-pushed
the
no-prompt-set-ns
branch
from
0b90c95 to
04f7966
Compare
bbatsov
reviewed
Mar 3, 2017
inf-clojure.el
Outdated
| @@ -179,6 +179,12 @@ This should usually be a combination of `inf-clojure-prompt' and | |||
| :type 'regexp | |||
| :group 'inf-clojure) | |||
|
|
|||
| (defcustom inf-clojure-prompt-when-set-ns t | |||
bbatsov
reviewed
Mar 3, 2017
inf-clojure.el
Outdated
| @@ -179,6 +179,12 @@ This should usually be a combination of `inf-clojure-prompt' and | |||
| :type 'regexp | |||
| :group 'inf-clojure) | |||
|
|
|||
| (defcustom inf-clojure-prompt-when-set-ns t | |||
| "Controls whether to prompt by default when switching namespace." | |||
There was a problem hiding this comment.
"by default" seems redundant here
bbatsov
reviewed
Mar 3, 2017
inf-clojure.el
Outdated
| Defaults to the ns of the current buffer." | ||
| (interactive (inf-clojure-symprompt "Set ns to" (clojure-find-ns))) | ||
| Defaults to the ns of the current buffer, always prompting before | ||
| setting, unless `inf-clojure-prompt-when-set-ns` is \"never\" or |
There was a problem hiding this comment.
I'm pretty sure "never" won't work - this is just a tag in the customize UI.
bbatsov
reviewed
Mar 3, 2017
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| ### New Features | |||
|
|
|||
| * [#34](https://github.com/clojure-emacs/inf-clojure/pull/34): Add support for socket REPL connections. | |||
| * [#46](https://github.com/clojure-emacs/inf-clojure/pull/46): Optinally disable prompt on `inf-clojure-set-ns`. | |||
There was a problem hiding this comment.
Make it possible to disable prompt...
The patch allow the user to disable the request "Set ns: ..." on C-c M-n. The default is to always prompt.
arichiardi
force-pushed
the
no-prompt-set-ns
branch
from
04f7966 to
ddad033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch allow the user to disable the request "Set ns: ..." on C-c
M-n. The default is to always prompt.
Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):
M-x checkdocwarnings(No need?) -> You've updated the readme (if adding/changing user-visible functionality)