Remove calls to redisplay from clojure-sort-ns

[tomdl89]

This avoids unwanted flicker when jumping from current location
to ns form and back. Especially useful when clojure-sort-ns is
called from before-save-hook, and would otherwise distract the user.

---

Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

• The commits are consistent with our contribution guidelines.
• You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
• You've run M-x checkdoc and fixed any warnings in the code you've written.
• You've updated the changelog (if adding/changing user-visible functionality).
• You've updated the readme (if adding/changing user-visible functionality).

Thanks!

[bbatsov]

Won't some save-excursion also tackle this?

Especially useful when clojure-sort-ns is
called from before-save-hook, and would otherwise distract the user.

Probably you should document this somewhere, otherwise you'll probably be the only user of the new functionality. :-)

[tomdl89]

The (redisplay) that jumps us up to the ns occurs within a save-excursion (see new ln 1829) so I'm not sure I understand how adding more save-excursions would fix this. Good point on the documentation. I should add that to the docstring.

[bbatsov]

The (redisplay) that jumps us up to the ns occurs within a save-excursion (see new ln 1829) so I'm not sure I understand how adding more save-excursions would fix this.

I wrote this without really reading the code. :-) I'm not quite sure what's the nature of the flicker you experience. From the redisplay's docstring it seems that the cursor shouldn't jump around, but I'm not familiar with the function.

[tomdl89]

The cursor jumps around because of the goto-char command (and then again because of the forward-sexp etc commands). Usually, save-excursion allows all of this to be done without redisplaying (so the user never sees the movement), however, I guess whoever wrote this code thought that the user would be reassured seeing the cursor jump up to the ns form and then back down again. I guess it confirms that something is happening? I added the suppress-redisplay? arg to allow the user to opt out. I would be fine with removing the redisplay calls, but presumably some users like to see the jumps? (When I wrote "flicker" I was just referring to fact that the jumps are so fast, btw).

[bbatsov]

I'd just remove the redisplay if it's not adding anything meaningful. I always prefer to delete code rather than add more code to deal with the existing code. :-)

[tomdl89]

Ok :) that was my preference all along, so suits me! Thanks

[bbatsov]

I think you shoudl also kill those surrounding sleeps, as I can't see why they would be needed.

[bbatsov]

I see one before and after the redisplay.

[bbatsov]

Thanks!