-
-
Notifications
You must be signed in to change notification settings - Fork 247
Enhance the add arity refactoring #541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We'll have to mention the bugfix in the changelog as well. Btw, does the command handle properly |
8f0c99e
to
c6b5122
Compare
Can you think of any other cases @bbatsov? |
What about |
Many thanks for your feedback @yuhan0. Wasn't even aware that it was possible to have multi-arity in a |
Support reader conditionals, letfn, fn, defmacro, defmethod, defprotocol, reify and proxy in addition to defn.
Nicely done! Now I've started wonder if we need a remove arity counterpart. :-) |
Hadn't thought of that. Guessing it will add very little value, but we'll never know until it's implemented. I'll give it a shot. |
Just came across a case which the current
clojure-add-arity
refactoring does not handle well i.e. when adefn
lies within a reader conditional. This pull request modifiesclojure-add-arity
to support this case.M-x checkdoc
and fixed any warnings in the code you've written.