Skip to content

[FIX #520] allow clojure-align-cond-forms to recognize qualified forms #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2019

Conversation

wandersoncferreira
Copy link
Contributor

I only extended the list of values at clojure-align-cond-forms to include the qualified versions of each symbol. Should be the most straightforward way to solve this issue.


Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):

  • The commits are consistent with our contribution guidelines.
  • You've added tests (if possible) to cover your change(s). Bugfix, indentation, and font-lock tests are extremely important!
  • You've run M-x checkdoc and fixed any warnings in the code you've written.
  • You've updated the changelog (if adding/changing user-visible functionality).
  • You've updated the readme (if adding/changing user-visible functionality).

Thanks!

…ualified forms

I only added the qualified names into the list of values. I think
that is the most straightforward way to solve this issue.
@bbatsov
Copy link
Member

bbatsov commented Jul 20, 2019

The solution looks reasonable to me, although the repetition annoys me a bit. @Malabarba is this fine by you?

@bbatsov bbatsov merged commit 2f90ebc into clojure-emacs:master Jul 24, 2019
@bbatsov
Copy link
Member

bbatsov commented Jul 24, 2019

Guess there are no objections from him.

@Malabarba
Copy link
Member

Sorry for the delay. I'm still managing my inbox overflow.
Yes, the change looks fine. Anything smarter than this would be beyond the scope of clojure-mode anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants