Fix compilation warnings #494 #521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Apr 9, 2019
| (beginning-of-defun) | ||
| (setq clojure-comment-start (point)) |
There was a problem hiding this comment.
clojure-comment-start was generating a warning and as far as I can tell It is unused? It may be that I'm missunderstanding something?
clojure-mode.el:2023:1:Warning: Unused lexical variable
‘clojure-comment-start’
There was a problem hiding this comment.
Hmm, I think that's supposed to be a buffer local variable. Let me take a closer look at the code - we might have made some real mistake. :-)
|
Sorry about the long radio silence! After a closer inspection of the changes I feel they are all safe. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compilation warnings as stated in #494.
M-x checkdocand fixed any warnings in the code you've written.