Fix #438 and better detection of doc-strings. #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You made a typo in the first commit message. As for the second - I'd replace "Better" with "Improve the" for the sake of consistency with our commit message style. |
bbatsov
reviewed
Aug 5, 2017
clojure-mode.el
Outdated
| @@ -584,7 +583,14 @@ If JUSTIFY is non-nil, justify as well as fill the paragraph." | |||
| (concat paragraph-separate "\\|\\s-*\".*[,\\.]$")) | |||
| (fill-column (or clojure-docstring-fill-column fill-column)) | |||
| (fill-prefix (clojure-docstring-fill-prefix))) | |||
| (fill-paragraph justify)) | |||
| (let* ((beg (nth 8 (syntax-ppss))) | |||
There was a problem hiding this comment.
I'd add some comment here explaining what this code does. Even I forget from time to time the behavior of functions like syntax-ppss, which is pretty easy with a name like this and absurd return values.
I guess it's time to change the glasses :/ Addressing comments and adding a small fix to the Makefile. |
|
@bbatsov ping ;) |
|
pong :-) |
mwfogleman
pushed a commit
to mwfogleman/clojure-mode
that referenced
this pull request
Sep 7, 2017
slipset
pushed a commit
to slipset/clojure-mode
that referenced
this pull request
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.