Skip to content

Add initial support for smartparens-mode. #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2016

Conversation

hrathod
Copy link
Contributor

@hrathod hrathod commented Jun 17, 2016

I have added some functionality to make smartparens-mode play nicely with clojure-mode by making the literal set notation and lambda shorthand notation easier to work with.

@Malabarba Malabarba merged commit b533580 into clojure-emacs:master Jun 17, 2016
@bbatsov
Copy link
Member

bbatsov commented Jun 18, 2016

This was merged before I could comment, but isn't setup like this one usually bundled with smartparens itself?

@expez
Copy link
Member

expez commented Jun 18, 2016

This was merged before I could comment, but isn't setup like this one usually bundled with smartparens itself?

Yes. It doesn't belong here.

@Fuco1
Copy link

Fuco1 commented Jun 19, 2016

We don't have setup for clojure yet though. @expez would you like to port this over?

@Malabarba
Copy link
Member

Sorry. Since we had something similar for paredit, I thought it was straightforward to do the same for smartparens.

@bbatsov
Copy link
Member

bbatsov commented Jun 19, 2016

The only reason we have the paredit code is that it's pretty hard to push any changes to paredit itself. I'm not opposed to having the smartparens code in clojure-mode, but I do believe it's best to follow the common sp conventions and the bundle the necessary config with it.

@Malabarba
Copy link
Member

👍 I agree.

@hrathod
Copy link
Contributor Author

hrathod commented Jun 20, 2016

Shall I create a new PR to revert these changes, then? Or has that already been done?

@Malabarba
Copy link
Member

I can revert the changes here. I was just waiting for someone to open a PR on https://github.com/Fuco1/smartparens

@hrathod hrathod deleted the hrathod/smartparen branch June 20, 2016 15:35
@Malabarba
Copy link
Member

I can revert the changes here. I was just waiting for someone to open a PR on https://github.com/Fuco1/smartparens

Since it is apparently agreed upon that this code should go in smartparens, and since this is causing other issues (#386) I decided not to wait.

@hrathod
Copy link
Contributor Author

hrathod commented Jun 20, 2016

Sorry for the troubles!

@Malabarba
Copy link
Member

Not at all! Thanks for the effort. :-)
The troubles were my fault.

@Fuco1
Copy link

Fuco1 commented Jun 22, 2016

In the meantime @vspinu has started (probably independently) an effort to add some settings: Fuco1/smartparens#593

Anyone want to jump in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants