-
-
Notifications
You must be signed in to change notification settings - Fork 247
Add initial support for smartparens-mode. #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This was merged before I could comment, but isn't setup like this one usually bundled with |
Yes. It doesn't belong here. |
We don't have setup for clojure yet though. @expez would you like to port this over? |
Sorry. Since we had something similar for paredit, I thought it was straightforward to do the same for smartparens. |
The only reason we have the paredit code is that it's pretty hard to push any changes to paredit itself. I'm not opposed to having the smartparens code in clojure-mode, but I do believe it's best to follow the common sp conventions and the bundle the necessary config with it. |
👍 I agree. |
Shall I create a new PR to revert these changes, then? Or has that already been done? |
I can revert the changes here. I was just waiting for someone to open a PR on https://github.com/Fuco1/smartparens |
Since it is apparently agreed upon that this code should go in smartparens, and since this is causing other issues (#386) I decided not to wait. |
Sorry for the troubles! |
Not at all! Thanks for the effort. :-) |
In the meantime @vspinu has started (probably independently) an effort to add some settings: Fuco1/smartparens#593 Anyone want to jump in? |
I have added some functionality to make
smartparens-mode
play nicely withclojure-mode
by making the literal set notation and lambda shorthand notation easier to work with.