Skip to content

Improve clojure-find-def matching (support hyphens) #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2015

Conversation

maio
Copy link
Contributor

@maio maio commented Oct 13, 2015

Custom def... macros might contain hyphens (e.g. defxxx-yyy).

@bbatsov
Copy link
Member

bbatsov commented Oct 13, 2015

A matching font-lock test is a prerequisite for this PR to be accepted.

@bbatsov
Copy link
Member

bbatsov commented Oct 13, 2015

My bad - I meant to say "does the font-locking code match this behaviour?".

@maio
Copy link
Contributor Author

maio commented Oct 15, 2015

OK, thanks for the feedback. I'll check that.

@bbatsov
Copy link
Member

bbatsov commented Oct 18, 2015

Great.

@bbatsov
Copy link
Member

bbatsov commented Oct 26, 2015

I plan to release clojure-mode 5.0 pretty soon, so if you want the PR in it you should wrap it in a day or two.

@maio
Copy link
Contributor Author

maio commented Oct 26, 2015

Is this test sufficient?

Custom def... macros might contain hyphens (e.g. defxxx-yyy).
@maio
Copy link
Contributor Author

maio commented Oct 26, 2015

I fixed the test.

bbatsov added a commit that referenced this pull request Oct 26, 2015
Improve clojure-find-def matching (support hyphens)
@bbatsov bbatsov merged commit 28a8286 into clojure-emacs:master Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants