Wrong indentation in multi-arity forms

[myguidingstar-zz]

Things are currently auto-indented like this:

(defn a-function
  ([x]
     x)
  ([x y]
     (+ x y)))

and

(fn a-function
  ([x]
     x)
  ([x y]
     (+ x y)))

[expez]

As a reference, here's how it usually looks.

(defn a-function
  [x y]
  (+ x y))

[bbatsov]

Yep, that's definitely a bug.

[wjlroe]

What is the desired behaviour here? Both vim's Clojure indentation and LightTable's indent thus:

(defn foo
  ([x] (bar x))
  ([x y]
   (if (predicate? x)
     (bar x)
     (baz x))))

(which looks weird to me, but I think I'm used to the way clojure-mode has been indenting these for a while now). I can't find any advice in any clojure style guides (including the referenced Scheme guide) about multiple-arity clojure indentation.

[expez]

What you just posted is the desired behavior. clojure-mode now indents the first form, of multi-arity function bodies with two spaces more than it should.

[zane]

I see this has the "help-needed" label. What would be useful?

[bbatsov]

It means that I don't have the time to deal with this soon. Basically, the problem is caused by us copying (inheriting) too much things from lisp-mode. We should reduce our reliance on lisp-mode.

[expez]

Should probably rename that label, @bbatsov might want some help, but he never needs it :p

[bbatsov]

@expez LOL

[vmfhrmfoaj]

Hi all,

Is it still a bug? already, some codes has used 3 space indent. (e.g. core.async/src/main/clojure/core/async.clj:78)
Anyway, it is related to the following code:

;; clojure-mode.el:718:clojure-indent-function:
(if (and (eq (char-after (point)) ?\[)
         (eq (char-after (elt state 1)) ?\())
    (+ (current-column) 2) ;; this is probably inside a defn
  (current-column))

and commits:

• 7c3a604
• ae5f46d

[expez]

@vmfhrmfoaj yes, this is still a bug. That code, in core.async, is probably written using emacs, and thus it's our fault it looks like that.