[Resolve #366] Add cljr-rename-ns-alias.
#440
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok ignore my last comment. I see I was wrongly using |
|
Hi, thanks for taking an interest @anthonygalea! This is great stuff! 👍 Since this is elisp only, do you think we should put this in clojure-mode @bbatsov? |
|
@anthonygalea Sorry about the slow response! Let's add this directly to |
|
No problem @bbatsov. Opened another pull request in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring works but I have an issue with the
Without :asscenario. I think it's related to the action chain but not sure how to fix it. My goal there is to ensure that if a rename is made for an alias which is not in therequirethe file is untouched.