Add colorwheel effect, refactor library #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's worth noting that while the library is new, this is technically API breaking! However the new API should be future proof. Using an enums instead of
isinstance()
because that would require importing the libraries even if they're not used, which could be a lot if more libraries are ever added. Also didn't want to use__qualname__
or anything like that because that means subclasses won't be recognized. Using explicit enums saves both the memory and allows effects to work for subclasses.