chore: update for ES2015 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was always bad advice but slipped through when transitioning from Coffeescript. It's been replaced with what the original intent was, which was to leave conditional logic in the render methed for readability.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
What
This PR updates all sections to use ES2015 syntax.
It also clarifies examples and makes corrections to errors introduced in the CoffeeScript -> JS/ES5 transition. The most noteworthy of these is the 180 degree turn on sub-renders.
I'm not sure how I made such a huge mistake in transposing the CS version but we have always held to the idea that logic should like in the
rendermethod and notsub-renderfunctions.Reference
Resolves #21