-
Notifications
You must be signed in to change notification settings - Fork 139
feat(skip-nav): create skip nav components and story #529
feat(skip-nav): create skip nav components and story #529
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TylerAPfledderer !
Thank you for this component PR. It's a great addition to v0. The code for this component looks good. However, it is missing some tests. Would like to add a few tests to make sure that the component keyboard interactions are functioning as expected?
This also will need a storybook example and a page in the docs. |
Hey @codebender828! First off, glad to see you are back. 🎉 🎺 I can certainly work on that. In the meantime, I'll switch this PR into a draft. |
I do have a story file committed. Is there anything else you want to add to it? I used the one from the react package. 😄 |
Did some digging inside the build logs. I think the reason the build here is failing is because there is no https://github.com/chakra-ui/chakra-ui-vue/runs/6865351302?check_suite_focus=true#step:6:25 For your reference, this is the config code: chakra-ui-vue/packages/chakra-ui-core/rollup.config.js Lines 83 to 89 in 0800981
|
Got it! And for added consistency, do you think it would also benefit adding an |
Yes! Good idea. Let's have the |
Hey @codebender828! I am attempting to push my new changes, but git is running testing on push and some tests are failing elsewhere in the package (related to Should I go ahead and try to force push? |
@codebender828 update: I can also disable the The test errors for those modules look to originate at nuxt utils. Let me know what you would like me to do. I have another PR I would like to push that is also affected by this. 😄 |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 13fed10:
|
@codebender828 I went ahead and skipped the husky |
Description
Create the
SkipNavLink
andSkipNavContent
componentsMotivation and Context
How Has This Been Tested?
Built story based on the story provided in the react package, but with more detail
Types of changes
Checklist: