Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

fix: close button customize color bug #417

Merged
merged 3 commits into from
Mar 31, 2021
Merged

Conversation

codebender828
Copy link
Collaborator

Description

Allows consumer to customize color of close button

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2021

⚠️ No Changeset found

Latest commit: fbbaa14

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Mar 31, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/4Nw86ziWSPmVLHT95ga3qANjRY7D
✅ Preview: https://chakra-ui-vue-git-fix-close-button-color-chakra-ui.vercel.app

Copy link
Collaborator

@carwack carwack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👏

Any idea why it was added in the first place? 😊

@codebender828
Copy link
Collaborator Author

codebender828 commented Mar 31, 2021

Looks good! 👏

Any idea why it was added in the first place? 😊

Not enough sleep? 😜

@carwack
Copy link
Collaborator

carwack commented Mar 31, 2021

Looks good! 👏
Any idea why it was added in the first place? 😊

Not enough sleep? 😜

Haha, fair enough 😂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants