Skip to content
This repository was archived by the owner on Sep 20, 2024. It is now read-only.

chore: Fixes props validator issue with CBotton component #260

Merged

Conversation

kurotanshi
Copy link
Contributor

Description

Fixes props validator issue with CBotton component, when size set to "xs".

Screenshots (if appropriate):

截圖 2020-07-17 下午3 46 39

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vercel
Copy link

vercel bot commented Jul 18, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/9whcqzdfj
✅ Preview: https://chakra-ui-vue-git-fork-kurotanshi-fix-cbutton-prop-validator.chakra-ui.vercel.app

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch here, @kurotanshi ! Thank you for the PR. 👍🏽

I've requested a small change to the validator to include the xs size.

Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @kurotanshi

@codebender828 codebender828 merged commit 0dd046c into chakra-ui:develop Jul 18, 2020
@codebender828
Copy link
Collaborator

@all-contributors please add @kurotanshi for code

@allcontributors
Copy link
Contributor

@codebender828

I've put up a pull request to add @kurotanshi! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants