Accessibility info added for Clink component #244
Conversation
Name added to contributors list
accessibility.md file added to brief the basic introductions on accessibility of CLink component
|
This pull request is being automatically deployed with Vercel (learn more). |
added quotes to render an '<a>' tag in WAI-ARIA compliance
There was a problem hiding this comment.
Nice work with this @saptaksengupta ! Thanks for taking on this task. I requested one change with regards to the context menu. Since it's optional, and not implemented on the CLink it's best to remove it so that users aren't confused.
Otherwise it looks good!
One thing to take note of in future is to test as you write the reports. I found lots of bugs while doing this and I was able to fix them in the process. I would go through each WAI-ARIA feature while testing it on the built component to make sure it's compliant. You may find a bug in this process. If you do, please feel free to open an issue for the discrepancy. If you think you can implement the fix as well you can go ahead and do it as well.
Otherwise, this is really great work! thank you!
|
|
||
| ### `CLink` Keyboard Interaction | ||
| - [x] **`Enter`**: Executes the link and moves focus to the link target. | ||
| - [x] **`Shift + F10 (Optional)`**: Opens a context menu for the link. |
There was a problem hiding this comment.
Since this is optional and not implemented on the CLink component I think we should remove it so readers aren't misled. 👍
There was a problem hiding this comment.
Sure @codebender828. I will remove it.
Thanks a lot for you valuable feedback. i will take care all of this in future.
keyboard interaction removed as that was optional in nature.
Accessibility.md file added for CLink Component
Description
Accessibility.md file added for CLink Component, based on aria document provided into [aria link docs] (https://www.w3.org/TR/wai-aria-practices-1.2/#link)
Motivation and Context
To provide a basic idea of accessibility features that are provided in CLink component.
How Has This Been Tested?
By Reviewing the Accessibility file in local branch
Screenshots (if appropriate):
Types of changes
Checklist: