Skip to content

Ac 178 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2021
Merged

Ac 178 #6

merged 3 commits into from
Jun 11, 2021

Conversation

ajnelson-nist
Copy link
Member

No description provided.

References:
* [AC-178] Add website repository's sample runner to
  CASE-Utilities-Python repository

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist changed the base branch from main to develop June 11, 2021 14:00
@ajnelson-nist
Copy link
Member Author

numpy requires Python >= 3.7.
https://pypi.org/project/numpy/

Need to think through how to resolve this.

This does not address the CI-reported python3.6 error, but it is a
necessary fix in the meanwhile.

References:
* [AC-178] Add website repository's sample runner to
  CASE-Utilities-Python repository

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
numpy, a pandas dependency, required Python > 3.7 as of version 1.20.0.
Hence, case_sparql_select cannot import pandas in a Python 3.6
environment.

This patch adds steps to disable dependency installation and tests for
case_sparql_select if Python is detected to be < 3.7.x.

As a reminder, Python 3.6 goes EOL on 2021-12-23.  By or at that time,
3.6 will be removed from this project.

References:
* [AC-178] Add website repository's sample runner to
  CASE-Utilities-Python repository
* [PEP-0494] https://www.python.org/dev/peps/pep-0494/#and-beyond-schedule
* [numpy 1.20.0] https://pypi.org/project/numpy/1.20.0/

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist merged commit c902db3 into develop Jun 11, 2021
@ajnelson-nist ajnelson-nist deleted the AC-178 branch June 11, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant