Add Python code formatting with Black as Make steps #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds two Make targets to the test environment so a manual format-review can be done: * Testing - `cd tests ; make check-black` * Formatting - `cd tests ; make format` Further discussion needs to be had before these are added to CI steps. A follow-on patch will apply Black, so mechanical effects can be separated from manual changes. References: * [AC-215] Evaluate pre-commit usage on casework repositories * [AC-216] Apply Black to all casework Python code bases Acked-by: kchason <kchason@users.noreply.github.com> Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [AC-216] Apply Black to all casework Python code bases Acked-by: kchason <kchason@users.noreply.github.com> Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series adds two Make targets to the test environment so a manual format-review can be done:
cd tests ; make check-blackcd tests ; make formatFurther discussion needs to be had before these are added to CI steps.
References: