Test in Python 3.6 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python Software Foundation is supporting Python 3.6 until 2021-12-23. CASE should test its tooling in Python 3.6 until that Python release reaches end-of-life. This patch is somewhat an XFAIL - I ran the unit tests in an Ubuntu 18.04 machine and found a feature used in a test is supported in Python >= 3.7. A follow-on patch will correct that issue. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
The prior patch worked in my local environment, but missed a nuance of Python 3.8 being available in Github's runner, though 3.6 is the action's configured version. The Makefile PYTHON3 variable does a newest-version-first search, so virtualenv wasn't found at runtime. The name of the action's Python 3 command was found via the home page of the setup-python action: https://github.com/marketplace/actions/setup-python Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
asovern-mitre
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python Software Foundation is supporting Python 3.6 until
2021-12-23.
CASE should test its tooling in Python 3.6 until that Python release
reaches end-of-life.
This patch is somewhat an XFAIL - I ran the unit tests in an Ubuntu
18.04 machine and found a feature used in a test is supported in
Python >= 3.7. A follow-on patch will correct that issue.
Signed-off-by: Alex Nelson alexander.nelson@nist.gov