Skip to content

Add and confirm prefix customization; start doctests #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 13, 2024
Merged

Add and confirm prefix customization; start doctests #39

merged 5 commits into from
Mar 13, 2024

Conversation

ajnelson-nist
Copy link
Member

This patch series is an isolated and expanded change drawn from PR 38.

This patch series was written to integrate into the current class hierarchy without disruption to existing code. This patch does not necessarily indicate agreement with the current class hierarchy.

@ajnelson-nist
Add and confirm prefix customization; start doctests
7434c6f 
This patch is an isolated and expanded change drawn from PR 38.

This patch was written to integrate into the current class hierarchy
without disruption to existing code.  This patch does not necessarily
indicate agreement with the current class hierarchy.

A follow-on patch will regenerate Make-managed files.

References:
* #38

Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Regenerate Make-managed files
cd887f8 
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Copy link
Member Author

I think a future change will need to adjust how the prefix label and IRI is determined. The top-level graph dictionary might need to be handled externally to the class hierarchy currently rooted in FacetEntity, e.g., so a non-default prefix_label can be used without needing to pepper it throughout the caller's code.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review March 12, 2024 18:43
@ajnelson-nist
Copy link
Member Author

ajnelson-nist commented Mar 12, 2024 •
edited
Loading

Also, this test adds an additional target to make check that is not yet repeated by the CI. I believe the test is worth running to prevent developer information leakage: file paths are potentially embeddable in data from Turtle generated from JSON-LD that supplies neither node prefixes nor a @base context dictionary directive.

@ajnelson-nist ajnelson-nist marked this pull request as draft March 12, 2024 18:47
@ajnelson-nist ajnelson-nist mentioned this pull request Mar 12, 2024
Merged
@ajnelson-nist
Align test
777a504 
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Adjust generated error message
c6d4f8b 
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist
Adapt prefix test for CI process
d578183 
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
@ajnelson-nist ajnelson-nist force-pushed the add_prefix_customization branch from 2cd837c to d578183 Compare March 12, 2024 21:10
@ajnelson-nist
Copy link
Member Author

Also, this test adds an additional target to make check that is not yet repeated by the CI.

Test has been added.

@ajnelson-nist ajnelson-nist marked this pull request as ready for review March 12, 2024 21:11
@ajnelson-nist
Copy link
Member Author

This PR is ready for review and merge.

@fabrizio-turchi fabrizio-turchi merged commit 9424c02 into main Mar 13, 2024
@ajnelson-nist ajnelson-nist deleted the add_prefix_customization branch June 11, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabrizio-turchi fabrizio-turchi Awaiting requested review from fabrizio-turchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ajnelson-nist @fabrizio-turchi