Validation errors need to be fixed

[red-ship-it]

Some of the exif in the Pillow is being taken in as integers this should be strings within the controlled dictionary
<xsd:integer> but must be a <xsd:string>

• Also the raster bitsperpixel also needs to be fixed along with adding some assertions

[red-ship-it]

Have implemented a fix for this however I have highlighted these as TODO as there may be a cleaner way to do this

Have replicated the fix across both Pillow and exifread repos so they can both work with the same solution even though each lib has different outputs for these variables.

fixing ints in what should only be strings in controlled dict:

CASE-Implementation-PyPI-Pillow/pillow_case/exif_node_maker.py

Lines 177 to 225 in b9e800d

	# :TODO The below feels a bit hacky probably a better way to do it
	if 'EXIF ExifImageLength' in controlled_dict.keys():
	graph.add((
	n_raster_facets,
	NS_UCO_OBSERVABLE.pictureHeight,
	rdflib.term.Literal(int(float(str(controlled_dict['EXIF ExifImageLength']))),
	datatype=NS_XSD.integer)
	))
	elif 'ExifImageHeight' in controlled_dict.keys():
	graph.add((
	n_raster_facets,
	NS_UCO_OBSERVABLE.pictureHeight,
	rdflib.term.Literal(int(float(str(controlled_dict['ExifImageHeight']))),
	datatype=NS_XSD.integer)
	))
	if 'EXIF ExifImageWidth' in controlled_dict.keys():
	graph.add((
	n_raster_facets,
	NS_UCO_OBSERVABLE.pictureWidth,
	rdflib.term.Literal(int(float(str(controlled_dict['EXIF ExifImageWidth']))),
	datatype=NS_XSD.integer)
	))
	elif 'ExifImageWidth' in controlled_dict.keys():
	graph.add((
	n_raster_facets,
	NS_UCO_OBSERVABLE.pictureWidth,
	rdflib.term.Literal(int(float(str(controlled_dict['ExifImageWidth']))),
	datatype=NS_XSD.integer)
	))
	if 'EXIF CompressedBitsPerPixel' in controlled_dict.keys():
	graph.add((
	n_raster_facets,
	NS_UCO_OBSERVABLE.bitsPerPixel,
	rdflib.term.Literal(int(float(str(controlled_dict['EXIF CompressedBitsPerPixel']))),
	datatype=NS_XSD.integer)
	))
	elif 'CompressedBitsPerPixel' in controlled_dict.keys():
	graph.add((
	n_raster_facets,
	NS_UCO_OBSERVABLE.bitsPerPixel,
	rdflib.term.Literal(int(float(str(controlled_dict['CompressedBitsPerPixel']))),
	datatype=NS_XSD.integer)
	))
	graph.add((
	n_raster_facets,
	NS_RDFS.comment,
	rdflib.Literal("Information represented here from exif information not from "
	"file system stats except for extension, which uses os python lib")
	))

fixing strings in what should only be ints:

CASE-Implementation-PyPI-Pillow/pillow_case/exif_node_maker.py

Lines 253 to 256 in b9e800d

	# :TODO stringing all values to ensure they are strings, open to input
	# here as maybe assertion or a better way to do this
	v_value = str(controlled_dict[key])
	v_value = rdflib.Literal(v_value)

[ajnelson-nist]

This looks like a job for static type enforcement. I have a patch brewing for case_utils that will show what I mean here.

[ajnelson-nist]

@red-ship-it , FYI:
casework/CASE-Utilities-Python#16