Skip to content

fix: add tvOS 16.0 availability check for toolbar API #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mtshv
Copy link
Contributor

@mtshv mtshv commented Feb 20, 2025

Problem:
The toolbar API availability check only includes iOS 16.0, causing build errors on tvOS targets. This was introduced by 024e92e#diff-89822b2e0d1364951af03c6bbf9b4e69b7e1f1ceca81ad7b242d48ba2195e5a3R355-R368

image

Solution:
Added tvOS 16.0 to the availability check to support both platforms.

Copy link

changeset-bot bot commented Feb 20, 2025

🦋 Changeset detected

Latest commit: 4e827da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
react-native-bottom-tabs Patch
@bottom-tabs/expo-template Patch
@bottom-tabs/react-navigation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@okwasniewski okwasniewski merged commit 99776e5 into callstackincubator:main Feb 20, 2025
7 checks passed
@fredrikburmester
Copy link

Sorry if this is the wrong place to post this. How do I get past this build error?
Screenshot 2025-02-21 at 19 19 23

@okwasniewski
Copy link
Collaborator

@fredrikburmester It should be fixed with this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants