fix: shutdown ImageLoader onDropViewInstance on android #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 137adaf The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt
Outdated
Show resolved
Hide resolved
johankasperi
force-pushed
the
recreate-android-imageloader-if-shutdown
branch
from
05a184e to
648fa69
Compare
| @@ -384,6 +384,10 @@ class ReactBottomNavigationView(context: Context) : LinearLayout(context) { | |||
| updateTextAppearance() | |||
| } | |||
|
|
|||
| fun shutdownImageLoader() { | |||
There was a problem hiding this comment.
nit: Can we call this onDropViewInstance? If in the future there is some other deinit code then we will have universal function to do so.
There was a problem hiding this comment.
Of course! Will fix asap
packages/react-native-bottom-tabs/android/src/newarch/RCTTabViewManager.kt
Show resolved
Hide resolved
johankasperi
force-pushed
the
recreate-android-imageloader-if-shutdown
branch
from
648fa69 to
574d8d6
Compare
johankasperi
changed the title
okwasniewski
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
imageLoader.shutdown()is calledonDetachedFromWindow. But this lifecycle method is called when opening a modal on top of the current view containing bottom tabs. When then closing the modal theImageLoaderhas been shutdown and wont load icons anymore. Solved this by checking ifimageLoaderis null in thegetDrawablemethod and if so creates it again.Fixes #309
How to test?