Skip to content

fix: tvOS compile error and appearance #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

douglowder
Copy link
Contributor

  • Change to have tab bar correctly appear on first render (otherwise has the default gray color, and won't have correct appearance until tab selection changes)
  • Fix compile error (UIFont.smallSystemFontSize unavailable on tvOS)

@okwasniewski
Copy link
Collaborator

Thanks for this! Looks like the issue with appearance is happening on iOS too, Im going to fix it in separate PR.

I will also rework the repo structure to be a monorepo so we can fit the Expo example and run tvOS/AndroidTV builds on CI to make sure it doesn't break all the time (sorry for that!)

Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@okwasniewski okwasniewski merged commit 4b8f2a6 into callstackincubator:main Nov 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants