fix: missing jsx/tsx in build #957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AugustinLF
approved these changes
Apr 19, 2022
|
@thymikee should we consider publishing the TS version? Will help to make sure that nothing else was missed. |
@AugustinLF I don't see it's needed, as it was a one-time thing. It would bloat the npm package and I'd like to avoid this if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently,
src/render.tsxis not being built by Babel, because it was changes to atsxextension, but Babel is only told to buildjsandts.Also, it seems the out directory is out of date in
package.json.Test plan
It now builds everything.