Skip to content

docs: fix textmatch broken link #903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

gkartalis
Copy link
Contributor

@gkartalis gkartalis commented Jan 20, 2022

Summary

When pressing the #TextMatch link in the docs under queries > options we aren't redirected anywhere due to capital letters included in the relative path of the header.

The same issue exists with the #Normalization link in the docs under precision.

Due to this the TextMatch and Normalization are not that visible and might cause confusion 🙈

This pr fixes both links.

Test plan

You can check the links provided below to test.

Broken Fixed
https://callstack.github.io/react-native-testing-library/docs/api-queries/#Normalization https://callstack.github.io/react-native-testing-library/docs/api-queries/#normalization
https://callstack.github.io/react-native-testing-library/docs/api-queries/#TextMatch https://callstack.github.io/react-native-testing-library/docs/api-queries/#textmatch

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thymikee thymikee merged commit a010ffd into callstack:main Jan 20, 2022
@gkartalis gkartalis deleted the gkartalis/textmatch-broken-link branch January 20, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants