Forward extra data to press event #828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Oct 15, 2021
thymikee
added a commit
to AugustinLF/react-native-testing-library
that referenced
this pull request
Nov 23, 2021
* origin/main: (24 commits) v8.0.0 chore(deps): bump dns-packet from 1.3.1 to 1.3.4 in /website (callstack#742) chore(deps-dev): bump @babel/preset-flow from 7.13.13 to 7.14.5 (callstack#765) chore(deps-dev): bump typescript from 4.4.2 to 4.4.4 (callstack#845) chore(deps-dev): bump release-it from 14.6.1 to 14.11.6 (callstack#830) chore(deps-dev): bump @babel/plugin-proposal-class-properties (callstack#846) chore(deps-dev): bump @babel/cli from 7.13.16 to 7.15.7 (callstack#833) chore(deps-dev): bump @testing-library/jest-native from 3.4.3 to 4.0.2 (callstack#842) chore(deps): bump color-string from 1.5.3 to 1.6.0 in /website (callstack#844) chore(deps): bump prismjs from 1.23.0 to 1.25.0 in /website (callstack#843) Forward extra data to press event (callstack#828) chore(deps-dev): bump @babel/preset-react from 7.13.13 to 7.14.5 (callstack#839) chore(deps): bump url-parse from 1.5.1 to 1.5.3 in /website (callstack#813) chore(deps-dev): bump @types/react from 17.0.2 to 17.0.30 (callstack#838) chore(deps): bump postcss from 7.0.29 to 7.0.36 in /website (callstack#756) chore(deps): bump prismjs from 1.23.0 to 1.25.0 in /website (callstack#823) chore(deps): bump path-parse from 1.0.6 to 1.0.7 in /website (callstack#796) chore(deps): bump merge-deep from 3.0.2 to 3.0.3 in /website (callstack#754) chore(deps): bump ws from 6.2.1 to 6.2.2 in /website (callstack#752) chore(deps): bump path-parse from 1.0.6 to 1.0.7 (callstack#795) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the
onPresscallbacks are called withundefined. While I think there should probably be a default value being passed, let's at least align the API withscrollandchangeTextTest plan
The added tests show exactly what changes, if you pass extra parameters to
fireEvent.press, they'll be forwarded to theonPresscallback.