Skip to content

docs update for fireEvent.onScroll() #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

CoryWritesCode
Copy link

Hello!

Summary

I had an issue where I was trying to test a SectionList component and I was trying to mock a scroll event but after the scroll event fired the component still never was found. I saw the data in the components props but not showing up to the test query. After chatting with Michał on the discord server he mentioned this was a constant issue he had to teach people about and he suggested changing my initialNumToRender prop or use an e2e test to verify. He also mentioned needing to update the docs at some point since he's had to teach this to people on a regular basis so I figured I'd go ahead and do it for him.

Let me know if there is anything I should change or that might be clearer. link to discord conversation

Test plan

Should be nothing other than spellchecking and correct terminology.

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thymikee thymikee merged commit 05455b1 into callstack:master Dec 11, 2020
@CoryWritesCode CoryWritesCode deleted the docs/add-clarity-and-examples-for-fireEvent-scroll branch December 11, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants