fix: display stack trace and code frame for findBy error #581
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #547 with a solution more or less copied from this file in dom-testing-library.
A useful stack trace and codeframe are now shown for
findBy
failures.Test plan
Note that to get the correct codeframe, the repo running the test must be another that uses this repo as a package, this won't work in the internal tests.
I didn't add any test because I'm not sure assertions on the stack trace make sense...
Contrary to the issue above, the stacktrace was already working with
waitFor
for me, so while it should improve the situation forwaitFor
calls too, I can't be sure of it.Improving the stack trace more
The stack trace still has 2 useless/internal lines, but I suspect to get rid of these, we must:
findBy***
helpers to capture the error hereI figured I would open this PR before digging more, since the most important part works :)