Skip to content

Fix the type bug for queryAllByTestId #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2020
Merged

Fix the type bug for queryAllByTestId #498

merged 1 commit into from
Aug 11, 2020

Conversation

BatDroid
Copy link
Contributor

@BatDroid BatDroid commented Aug 11, 2020 •
edited by thymikee
Loading

Summary

Fixes #486

Test plan

thymikee
thymikee approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thymikee thymikee merged commit 6bf86f9 into callstack:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typescript diff for queryAllByTestId says it can return null
2 participants
@BatDroid @thymikee