Skip to content

Update README.md - links to external resources #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2020
Merged

Update README.md - links to external resources #446

merged 2 commits into from
Jul 21, 2020

Conversation

vanGalilea
Copy link
Contributor

Summary

Hi I've added a blog post that I wrote about testing with the library. Same goes to my examples repo, that became very popular lately.

Test plan

@vanGalilea
Copy link
Contributor Author

https://twitter.com/kentcdodds/status/1284253978448945153?s=19

@mdjastrzebski mdjastrzebski changed the title Update README.md Update README.md - links to external resources Jul 20, 2020
mdjastrzebski
mdjastrzebski reviewed Jul 20, 2020
View reviewed changes
Copy link
Member

@mdjastrzebski mdjastrzebski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good.

I suggest putting the external resources section below Migration Guides section.

@vanGalilea
Copy link
Contributor Author

@mdjastrzebski done 👍

thymikee
thymikee approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks!

@thymikee thymikee merged commit 1537de3 into callstack:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdjastrzebski mdjastrzebski mdjastrzebski left review comments

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vanGalilea @thymikee @mdjastrzebski