Documentation update for The Problem section, Enzyme, benefits #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g Enzyme capabilities while highlighting more react-native-testing-library benefits
thymikee
approved these changes
Oct 21, 2018
Esemesek
approved these changes
Oct 21, 2018
|
Thanks @shawnaxsom, appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated to better compare with Enzyme capabilities while highlighting more react-native-testing-library benefits.
It is good for people to know the options (that Enzyme can technically be used currently for deep rendering), but also further sell the potential user on the benefits of react-native-testing-library.
This fixes #24.
I left out links to the Enzyme discussions, as it is up to the maintainers to include those and the goal is to highlight benefits while being fair.
Thanks for your consideration, and providing a great alternative to Enzyme!
Test plan
See enzymejs/enzyme#1873, where I have submitted an Enzyme PR to update testing instructions for Enzyme. There I mention how Enzyme does plan an adapter to support deep rendering, but that is still open, while I also show how jsdom can be implemented in Enzyme to use deep rendering (as we accomplished in our React Native boilerplate solution https://github.com/ProminentEdge/mobile-boilerplate).