fix(breaking): getByTestId should work only for native elements
#324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #270 |
mdjastrzebski
changed the title
getByTestId should work only for native elements
thymikee
changed the title
getByTestId should work only for native elementsgetByTestId should work only for native elements
thymikee
approved these changes
May 18, 2020
thymikee
reviewed
May 18, 2020
thymikee
pushed a commit
that referenced
this pull request
May 18, 2020
* Replaced getByTestId with fixed version * Added tests * Fixed flow-check * Updated docs * Fixed lint error * Used getByTestId in unit tests instead of queryByTestId * Updated negative checks in tests
thymikee
pushed a commit
that referenced
this pull request
May 28, 2020
* Replaced getByTestId with fixed version * Added tests * Fixed flow-check * Updated docs * Fixed lint error * Used getByTestId in unit tests instead of queryByTestId * Updated negative checks in tests
|
Is there some documentation that needs to be updated regarding this? My |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Existing version of
getByTestIdhad a bug (#270) as it returned also non-native elements. This was in contract withgetAllByTestIdwhich returned only native elements.Test plan
Added tests checking
getByTestIdbehavior.