feat: Support for @testing-library/jest-native #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
May 15, 2020
thymikee
reviewed
May 15, 2020
thymikee
reviewed
May 15, 2020
* Basic async findBy queries * Refactored findBy queries to be built with makeFindQuery * findBy queries for A11y selectors * Custom findByTestId implementation that avoids current getByTestId issues * Fixed prettier issue * Updates Queries.md with findBy queries * Trying to fix test timeout error appearing only on CI * Code review changes * Added typescript types & tests * prettier did reformat some code arround * Removed export of GetByAPI, QueryByAPI and FindByAPI interfaces in TS * Reversed prettier run on typings * Added overlapping pieces with `within` operator * Small cleanup * Update website/docs/Queries.md * Moved async/await tests to the end of test methods Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
* chore: bump eslint config to latest * lint fix * lint pass * use roles directly
cross19xx
reviewed
May 17, 2020
cross19xx
changed the title
…ation # Conflicts: # yarn.lock
thymikee
approved these changes
May 18, 2020
|
@cross19xx This seems to be actually @testing-library/jest-native issue with incomplete flow typings, as they are inferred by flow, and not exported by library. So the code works correctly in runtime, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added support for @testing-library/jest-native matchers by providing unit tests in our project, as well as documentation for setting up these matchers.
Fixes #298
Test plan
Added unit tests for @testing-library/jest-native matchers. Run
yarn test