Skip to content

Added usage notes for ByTestId queries #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 14, 2020

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented May 14, 2020

Summary

Based on this issue I've updated the docs for ByTestId queries.

Closes #303

Test plan

Not applicable.

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use some cool new features of Docusaurus, like callouts! https://v2.docusaurus.io/docs/markdown-features/#calloutsadmonitions

Would appreciate a screenshot of how it looks after suggestions applied :)

mdjastrzebski and others added 2 commits May 14, 2020 10:04
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
@mdjastrzebski
Copy link
Member Author

Docosaurus preview:

image

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LIT

@thymikee thymikee merged commit 51bd418 into callstack:master May 14, 2020
@mdjastrzebski mdjastrzebski deleted the fix/bytestid-usage-notes branch May 19, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs to mention buggy behavior of getByTestId and queryByTestId
2 participants