Skip to content

docs: add Redux example #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2020
Merged

docs: add Redux example #291

merged 2 commits into from
May 5, 2020

Conversation

cross19xx
Copy link
Contributor

@cross19xx cross19xx commented May 4, 2020

Examples to include the following:

  • Integration with Redux

Summary

Test plan

@thymikee
Copy link
Member

thymikee commented May 4, 2020

Yay! Now that we have multiple examples, we need to come up with a way to test them. I think it makes sense to make RNTL a Yarn workspace so that we can install deps once and use Jest's project config. The structure would look like this:

/ # root
  packages/
    react-native-testing-library/ # whole lib moved here
  examples/
    redux/
    react-navigation/
    ...

@thymikee
Copy link
Member

thymikee commented May 4, 2020

Let's make this PR only about Redux interaction, remove anything that's not specific to the tests. We need to keep examples short, scoped and to the point to avoid maintenance burden. It's crucial

@cross19xx
Copy link
Contributor Author

Yay! Now that we have multiple examples, we need to come up with a way to test them. I think it makes sense to make RNTL a Yarn workspace so that we can install deps once and use Jest's project config. The structure would look like this:

/ # root
  packages/
    react-native-testing-library/ # whole lib moved here
  examples/
    redux/
    react-navigation/
    ...

This I believe will be cool. But do you agree this has to be done later?

@thymikee thymikee marked this pull request as ready for review May 5, 2020 08:50
@thymikee thymikee changed the title docs: Include examples docs: add Redux example May 5, 2020
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's more like it! Later on, we can focus on providing helpers to test Redux connected components, like wrapInReduxContext(component) etc

@thymikee thymikee merged commit ae3d4af into master May 5, 2020
@thymikee thymikee deleted the examples branch May 5, 2020 08:51
@thymikee thymikee mentioned this pull request May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants